Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we insert the match inputs after the variables that are use… #7146

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Make sure we insert the match inputs after the variables that are use… #7146

merged 1 commit into from
Jan 27, 2025

Conversation

ilyalesokhin-starkware
Copy link
Contributor

…d in the arms.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-lowering/src/optimizations/test_data/reorder_statements line 392 at r1 (raw file):

    bool::False(v3) => blk1,
    bool::True(v4) => blk2,
  })

The changes enable using the match optimization in this case.

Suggestion:

Parameters:
blk0 (root):
Statements:
  (v0: ()) <- struct_construct()
  (v1: core::bool) <- bool::True(v0)
  (v2: core::felt252) <- 5
End:
  Match(match_enum(v1) {
    bool::False(v3) => blk1,
    bool::True(v4) => blk2,
  })

orizi
orizi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

orizi
orizi approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

ilyalesokhin-starkware
ilyalesokhin-starkware commented Jan 27, 2025
View reviewed changes
Copy link
Contributor Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 11 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 42c370c Jan 27, 2025
48 checks passed
@orizi orizi deleted the ilya/reorder_statements branch January 29, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orizi orizi orizi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyalesokhin-starkware @reviewable-StarkWare @orizi